Skip to content

update compose-go#10335

Merged
ndeloof merged 1 commit intodocker:v2from
ndeloof:ForServices
Mar 1, 2023
Merged

update compose-go#10335
ndeloof merged 1 commit intodocker:v2from
ndeloof:ForServices

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Mar 1, 2023

What I did
bump compose-go

  • use updated ForServices with options to implement --no-deps flag
  • pass selected profiles to loader to avoid loading disabled services environment

#closes #8713

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.10 ⚠️

Comparison is base (a99a0b5) 74.18% compared to head (8f15578) 73.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10335      +/-   ##
==========================================
- Coverage   74.18%   73.09%   -1.10%     
==========================================
  Files           2        2              
  Lines         275      275              
==========================================
- Hits          204      201       -3     
- Misses         60       62       +2     
- Partials       11       12       +1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 71.31% <0.00%> (-1.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof requested review from a team, StefanScherer, glours, laurazard, milas, nicksieger and ulyssessouza and removed request for a team March 1, 2023 14:50
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof enabled auto-merge (rebase) March 1, 2023 16:03
@ndeloof ndeloof merged commit a3bed26 into docker:v2 Mar 1, 2023
@ndeloof ndeloof deleted the ForServices branch March 1, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.env file referenced underneath env_file in a compose file is being parsed when file is not used.

3 participants