also restart dependent services after a service has been restarted#10273
Merged
also restart dependent services after a service has been restarted#10273
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2719636 to
39affdf
Compare
Codecov ReportBase: 72.79% // Head: 73.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10273 +/- ##
==========================================
+ Coverage 72.79% 73.89% +1.10%
==========================================
Files 2 2
Lines 272 272
==========================================
+ Hits 198 201 +3
+ Misses 62 60 -2
+ Partials 12 11 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
laurazard
approved these changes
Feb 13, 2023
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
55fc884 to
fde8de4
Compare
Contributor
Author
|
Also created compose-spec/compose-spec#305 so that user can explicitly opt-in/out for service to be restarted after a dependency has been restarted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
As a service is restarted, restart dependent services to ensure they can access the restarted container, which is required when those are set to share namespaces.
Introduce
--no-depsflag for those who prefer the legacy behavior, still disabled by default to enforce a predictable restart as side-effects of unshared namespaces is hard to diagnose.Related issue
close #10263
(not mandatory) A picture of a cute animal, if possible in relation to what you did