Skip to content

ignore services without a build section#10271

Merged
ndeloof merged 1 commit intodocker:v2from
ndeloof:watch_no_build
Feb 14, 2023
Merged

ignore services without a build section#10271
ndeloof merged 1 commit intodocker:v2from
ndeloof:watch_no_build

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Feb 13, 2023

What I did
Ignore services without a build section, return error if explicitly selected

Related issue
close #10270

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested review from a team, StefanScherer, glours, laurazard, milas, nicksieger and ulyssessouza and removed request for a team February 13, 2023 09:11
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 73.89% // Head: 72.79% // Decreases project coverage by -1.11% ⚠️

Coverage data is based on head (a5aaeba) compared to base (0612b34).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10271      +/-   ##
==========================================
- Coverage   73.89%   72.79%   -1.11%     
==========================================
  Files           2        2              
  Lines         272      272              
==========================================
- Hits          201      198       -3     
- Misses         60       62       +2     
- Partials       11       12       +1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 70.98% <0.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof force-pushed the watch_no_build branch 2 times, most recently from 94750be to a724e34 Compare February 13, 2023 11:18
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof merged commit 313b82e into docker:v2 Feb 14, 2023
@ndeloof ndeloof deleted the watch_no_build branch February 14, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] watch: can't watch a service without a build section

2 participants