Skip to content

add buildx plugin to e2e configuration directory#10113

Merged
glours merged 5 commits intodocker:v2from
glours:add-buildx-plugin-e2e
Dec 21, 2022
Merged

add buildx plugin to e2e configuration directory#10113
glours merged 5 commits intodocker:v2from
glours:add-buildx-plugin-e2e

Conversation

@glours
Copy link
Contributor

@glours glours commented Dec 21, 2022

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
We can't run locally e2e tests which need to configure buildx builder. I added a function to copy a specific CLI plugin to the e2e configuration directory and be sure the plugin will be available to run tests

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours requested review from a team and ulyssessouza December 21, 2022 14:23
@glours glours self-assigned this Dec 21, 2022
@glours glours requested review from StefanScherer, laurazard, milas, ndeloof and nicksieger and removed request for a team December 21, 2022 14:24
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the add-buildx-plugin-e2e branch from 965d0a5 to 935968f Compare December 21, 2022 14:27
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge December 21, 2022 14:37
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
currently the version displayed is the one installed and not the one use for the tests

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the add-buildx-plugin-e2e branch from 518874e to 183a092 Compare December 21, 2022 18:43
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the add-buildx-plugin-e2e branch 3 times, most recently from 5763b92 to be38d1a Compare December 21, 2022 19:58
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the add-buildx-plugin-e2e branch from be38d1a to 5dcadc0 Compare December 21, 2022 20:09
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 75.79% // Head: 73.01% // Decreases project coverage by -2.78% ⚠️

Coverage data is based on head (5dcadc0) compared to base (91371fe).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10113      +/-   ##
==========================================
- Coverage   75.79%   73.01%   -2.79%     
==========================================
  Files           2        2              
  Lines         252      289      +37     
==========================================
+ Hits          191      211      +20     
- Misses         53       65      +12     
- Partials        8       13       +5     
Impacted Files Coverage Δ
pkg/e2e/framework.go 71.32% <50.00%> (-2.72%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours merged commit 6c537cc into docker:v2 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants