Skip to content

fix security opts support (seccomp and unconfined)#10110

Merged
ndeloof merged 2 commits intodocker:v2from
ndeloof:parseSecurityOpts
Dec 21, 2022
Merged

fix security opts support (seccomp and unconfined)#10110
ndeloof merged 2 commits intodocker:v2from
ndeloof:parseSecurityOpts

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 21, 2022

What I did
diverge from docker/cli ParseSecurityOpts by avoiding mutation of the source slice

Related issue
closes #9458
closes #9505

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof ndeloof changed the title mutability is hell fix security opts support (seccomp and unconfined) Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 75.79% // Head: 76.98% // Increases project coverage by +1.19% 🎉

Coverage data is based on head (e61c967) compared to base (91371fe).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10110      +/-   ##
==========================================
+ Coverage   75.79%   76.98%   +1.19%     
==========================================
  Files           2        2              
  Lines         252      252              
==========================================
+ Hits          191      194       +3     
+ Misses         53       51       -2     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 75.31% <0.00%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, StefanScherer, glours, laurazard, milas, nicksieger and ulyssessouza and removed request for a team December 21, 2022 08:25
@ndeloof ndeloof merged commit 9f7ad18 into docker:v2 Dec 21, 2022
@ndeloof ndeloof deleted the parseSecurityOpts branch December 21, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security option systempaths=unconfined unsupported by compose. Docker compose not working with seccomp file and replicas together

2 participants