Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/compose
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.29.2
Choose a base ref
...
head repository: docker/compose
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.29.3
Choose a head ref
  • 19 commits
  • 55 files changed
  • 11 contributors

Commits on Aug 16, 2024

  1. allow to add empty line in the logs when nav menu activated

    Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
    glours committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    11c7a25 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. docs(wait): Fix wait command description

    Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
    idsulik authored and ndeloof committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    98e261b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. docs: duplicate documentation for root cmd

    Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
    dvdksn authored and ndeloof committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6e172d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. prefer mount API over bind

    Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
    ndeloof authored and jhrotko committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f9c7a0c View commit details
    Browse the repository at this point in the history
  2. service hash must exlude depends_on

    Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
    ndeloof authored and jhrotko committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d658fec View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Allow combination of bind mounts and 'rebuild' watches

    Signed-off-by: Remco Kranenburg <remco.kranenburg@crunchr.com>
    Remco Kranenburg authored and ndeloof committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e6ef862 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Fix typo in pull.go

    Signed-off-by: jonathan-dev <jonathan.drude@gmail.com>
    jonathan-dev authored and glours committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b633c5c View commit details
    Browse the repository at this point in the history
  2. attach: close streams when done

    When Compose is watching a project/reattaching streams on container
    start, it will make new API `ContainerAttach()` calls every time a
    container it's watching is started. However, it only closes the stream
    when the context used to start the attach is canceled.
    
    This means that if a user has a project with multiple containers where
    containers keep restarting, Compose will attach to the new containers
    but never close the previous streams, causing fds to pile up and
    goroutines on the engine to get stuck.
    
    Signed-off-by: Laura Brehm <laurabrehm@hey.com>
    laurazard authored and glours committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    329ad73 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Use logrus instead of direct output to stderr.

    Signed-off-by: Felix Fontein <felix@fontein.de>
    felixfontein authored and ndeloof committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1d608e0 View commit details
    Browse the repository at this point in the history
  2. Fix typos

    Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
    NathanBaulch authored and glours committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    524a97e View commit details
    Browse the repository at this point in the history
  3. build(deps): bump golang.org/x/sys from 0.22.0 to 0.25.0

    Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.22.0 to 0.25.0.
    - [Commits](golang/sys@v0.22.0...v0.25.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/sys
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and glours committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1505932 View commit details
    Browse the repository at this point in the history
  4. bump dependencies versions, engine and cli v27.2.1

    containerd v1.7.22
    buildx v0.17.0
    buildkit v0.16.0
    
    Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
    glours committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ef46445 View commit details
    Browse the repository at this point in the history
  5. bump golang to version 1.22.7

    Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
    glours committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f592aad View commit details
    Browse the repository at this point in the history
  6. fix linting issues with golangci-lint 1.60.2

    pkg/watch/watcher_darwin.go:96:16: Error return value of `d.stream.Start` is not checked (errcheck)
            d.stream.Start()
                          ^
        pkg/prompt/prompt.go:97:12: Error return value of `fmt.Fprint` is not checked (errcheck)
            fmt.Fprint(u.stdout, message)
                      ^
        pkg/prompt/prompt.go:99:12: Error return value of `fmt.Scanln` is not checked (errcheck)
            fmt.Scanln(&answer)
                      ^
        cmd/formatter/logs.go:118:15: Error return value of `fmt.Fprintf` is not checked (errcheck)
                    fmt.Fprintf(w, "%s%s%s\n", p.prefix, timestamp, line)
                               ^
        cmd/formatter/logs.go:120:15: Error return value of `fmt.Fprintf` is not checked (errcheck)
                    fmt.Fprintf(w, "%s%s\n", p.prefix, line)
                               ^
        pkg/progress/json.go:67:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
                fmt.Fprintln(p.out, string(marshal))
                            ^
        pkg/progress/json.go:87:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
                fmt.Fprintln(p.out, string(marshal))
                            ^
        pkg/progress/plain.go:47:14: Error return value of `fmt.Fprintln` is not checked (errcheck)
            fmt.Fprintln(p.out, prefix, e.ID, e.Text, e.StatusText)
                        ^
        pkg/progress/tty.go:162:12: Error return value of `fmt.Fprint` is not checked (errcheck)
            fmt.Fprint(w.out, b.Column(0).ANSI)
                      ^
        pkg/progress/tty.go:165:12: Error return value of `fmt.Fprint` is not checked (errcheck)
            fmt.Fprint(w.out, aec.Hide)
                      ^
        pkg/compose/attach.go:53:13: Error return value of `fmt.Fprintf` is not checked (errcheck)
            fmt.Fprintf(s.stdout(), "Attaching to %s\n", strings.Join(names, ", "))
                       ^
        pkg/compose/compose.go:194:6: emptyStringTest: replace `len(dependencies) > 0` with `dependencies != ""` (gocritic)
                if len(dependencies) > 0 {
                   ^
        pkg/compose/convergence.go:461:2: builtinShadow: shadowing of predeclared identifier: max (gocritic)
            max := 0
            ^
        pkg/compose/run.go:127:5: emptyStringTest: replace `len(opts.User) > 0` with `opts.User != ""` (gocritic)
            if len(opts.User) > 0 {
               ^
        pkg/compose/run.go:139:5: emptyStringTest: replace `len(opts.WorkingDir) > 0` with `opts.WorkingDir != ""` (gocritic)
            if len(opts.WorkingDir) > 0 {
               ^
        pkg/compose/viz.go:91:8: emptyStringTest: replace `len(portConfig.HostIP) > 0` with `portConfig.HostIP != ""` (gocritic)
                        if len(portConfig.HostIP) > 0 {
                           ^
        cmd/compatibility/convert.go:66:6: emptyStringTest: replace `len(arg) > 0` with `arg != ""` (gocritic)
                if len(arg) > 0 && arg[0] != '-' {
                   ^
        pkg/e2e/watch_test.go:208:25: printf: non-constant format string in call to gotest.tools/v3/poll.Continue (govet)
                    return poll.Continue(res.Combined())
                                         ^
        pkg/e2e/watch_test.go:290:25: printf: non-constant format string in call to gotest.tools/v3/poll.Continue (govet)
                    return poll.Continue(r.Combined())
                                         ^
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah authored and glours committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d445ebb View commit details
    Browse the repository at this point in the history
  7. Restore compose v1 behavior to recreate containers when ran with -V

    Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
    ndeloof authored and glours committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a742443 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. bump compose-go to version v2.2.0

    Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
    glours committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8db0cba View commit details
    Browse the repository at this point in the history
  2. build(deps): bump golang.org/x/sync from 0.7.0 to 0.8.0

    Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.7.0 to 0.8.0.
    - [Commits](golang/sync@v0.7.0...v0.8.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/sync
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and glours committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    155f641 View commit details
    Browse the repository at this point in the history
  3. chore(watch): Add changed files path/count to log

    Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
    idsulik authored and glours committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2e14191 View commit details
    Browse the repository at this point in the history
  4. show sync files only in debug level

    Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
    idsulik authored and glours committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8bf0627 View commit details
    Browse the repository at this point in the history
Loading