Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max requested a review from thaJeztah May 19, 2025 12:15
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review May 19, 2025 12:17
Comment on lines +172 to +174
if curr.Hidden {
cliDoc.Hidden = true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should keep these for the YAML docs (being more "data" then "end-result")?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML file is still generated. What's changed is hidden attribute is now inherited from parent if set: https://github.com/docker/cli-docs-tool/pull/65/files#diff-cce07c459f10c3f29f937920cb8ba11cc3ab7028890917e036b3241da8940febR28

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! Sorry ignore me then 🤗

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max merged commit 7fde0e5 into docker:main May 19, 2025
6 checks passed
@crazy-max crazy-max deleted the hidden-inherit branch May 19, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants