update to go1.23, update golangci-lint to v1.62, fix linting issues #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 67.73% 67.73%
=======================================
Files 5 5
Lines 623 623
=======================================
Hits 422 422
Misses 139 139
Partials 62 62 ☔ View full report in Codecov by Sentry. |
clidocstool_yaml_test.go:63:60: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
filepath.Walk(tmpdir, func(path string, info fs.FileInfo, err error) error {
^
clidocstool_man_test.go:80:60: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
filepath.Walk(tmpdir, func(path string, info fs.FileInfo, err error) error {
^
clidocstool_test.go:52:31: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
Run: func(cmd *cobra.Command, args []string) {},
^
clidocstool_md_test.go:65:60: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
filepath.Walk(tmpdir, func(path string, info fs.FileInfo, err error) error {
^
clidocstool_test.go:68:13: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
Run: func(cmd *cobra.Command, args []string) {},
^
clidocstool_test.go:89:17: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
Run: func(cmd *cobra.Command, args []string) {},
^
clidocstool_yaml.go:80:19: unused-parameter: parameter 's' seems to be unused, consider removing or renaming it as _ (revive)
emptyStr := func(s string) string { return "" }
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Update config file for the new version, and removed some linters that were
deprecated and removed;
WARN The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
ERRO [linters_context] deadcode: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] varcheck: This linter is fully inactivated: it will not produce any reports.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
e3fec08 to
25dc041
Compare
crazy-max
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix linting issues (revive)
update golangci-lint to v1.62
Update config file for the new version, and removed some linters that were
deprecated and removed;
update to go1.23