replace uses of os/ioutil, and use test.TempDir() in tests #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The os/ioutil package is now deprecated, so replace with os. While at it, also replace its used for test.TempDir() in tests, which is easier to use as it is automatically cleaned up. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Feb 23, 2022
Comment on lines
-45
to
+42
| fres := filepath.Join(tmpdir, tt) | ||
| require.FileExists(t, fres) | ||
| bres, err := ioutil.ReadFile(fres) | ||
| bres, err := os.ReadFile(filepath.Join(tmpdir, tt)) |
Member
Author
There was a problem hiding this comment.
The require.FileExists() check felt a bit redundant here, as os.ReadFile() will already return an error if the file doesn't exist (which would also include the name of the missing file.
Member
Author
|
@crazy-max ptal (found this one in my local fork 😂) |
crazy-max
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The os/ioutil package is now deprecated, so replace with os. While at it,
also replace its used for test.TempDir() in tests, which is easier to use
as it is automatically cleaned up.