Wait for running condition before resizing#847
Closed
mlaventure wants to merge 1 commit intodocker:masterfrom
Closed
Wait for running condition before resizing#847mlaventure wants to merge 1 commit intodocker:masterfrom
mlaventure wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
7760192 to
b8f94bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
==========================================
- Coverage 53.19% 52.91% -0.29%
==========================================
Files 246 244 -2
Lines 16021 15849 -172
==========================================
- Hits 8522 8386 -136
+ Misses 6929 6909 -20
+ Partials 570 554 -16 |
Member
|
@mlaventure @tonistiigi guess we can close this one, now that moby/moby#37172 was merged? |
Contributor
Author
|
Yeah, I think we can drop this one now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com
- What I did
Delayed the initial resize call until the running wait condition is satisfied
Depends on moby/moby#36147
- How I did it
- How to verify it
In debug mode a call to the wait endpoint will be done before the first resize.
- Description for the changelog
Fix an issue where the initial resize could be missed by the container/exec
- A picture of a cute animal (not mandatory but encouraged)