Copy streamformatter and progress packages from github.com/moby/moby#6570
Closed
austinvazquez wants to merge 2 commits intodocker:masterfrom
Closed
Copy streamformatter and progress packages from github.com/moby/moby#6570austinvazquez wants to merge 2 commits intodocker:masterfrom
austinvazquez wants to merge 2 commits intodocker:masterfrom
Conversation
efb8d36 to
e3f671a
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…tter Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
e3f671a to
736a5b4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dependency on github.com/moby/moby/api/pkg/streamformatter and github.com/moby/moby/api/pkg/progress by copying these packages into internal packages within the CLI repository. This change promotes golang.org/x/time from an indirect to a direct dependency.
Key changes:
- Copied streamformatter and progress packages to internal/
- Updated all import paths across the codebase to reference the new internal packages
- Promoted golang.org/x/time to direct dependency in vendor.mod
Reviewed Changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vendor.mod | Promoted golang.org/x/time from indirect to direct dependency |
| internal/streamformatter/streamformatter.go | Added internal copy with refactored parameter names and receiver methods |
| internal/streamformatter/streamformatter_test.go | Added comprehensive test coverage for the copied package |
| internal/progress/progressreader_test.go | Added test coverage for progress reader functionality |
| cli/command/swarm/progress/root_rotation.go | Updated imports to reference internal packages |
| cli/command/service/progress/progress.go | Updated imports to reference internal packages |
| cli/command/service/progress/progress_test.go | Updated imports to reference internal packages |
| cli/command/image/build/context.go | Updated imports to reference internal packages |
| cli/command/image/build.go | Updated imports to reference internal packages |
| cli/command/container/run_test.go | Updated imports to reference internal packages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Oct 20, 2025
cpuguy83
approved these changes
Oct 23, 2025
Collaborator
cpuguy83
left a comment
There was a problem hiding this comment.
This LGTM.
Its a tiny bit of code that really doesn't belong in the moby API pacakge.
Member
|
replaced by moby/moby#51153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Copied github.com/moby/moby/api/pkg/streamformatter and github.com/moby/moby/api/pkg/progress to internal packages.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)