[27.x] cli/command/completion: alias ValidArgsFn instead of strong type#5828
Closed
thaJeztah wants to merge 1 commit intodocker:27.xfrom
Closed
[27.x] cli/command/completion: alias ValidArgsFn instead of strong type#5828thaJeztah wants to merge 1 commit intodocker:27.xfrom
thaJeztah wants to merge 1 commit intodocker:27.xfrom
Conversation
This may help with signature changes in Cobra 1.9.0, which defines a new CompletionFunc type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 27.x #5828 +/- ##
=======================================
Coverage 58.58% 58.58%
=======================================
Files 346 346
Lines 29322 29322
=======================================
Hits 17178 17178
Misses 11171 11171
Partials 973 973 |
This was referenced Feb 16, 2025
|
I confirm your fix should work. But please note I provided a PR to fix the issue in cobra |
Member
Author
|
Thanks! I opened a draft PR to verify current Cobra |
|
I can second @ccoVeille that this does build successfully with cobra v1.9.0 |
Member
Author
|
Let me close this one, as we don't need it now that cobra updated things in v1.9.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may help with signature changes in Cobra 1.9.0, which defines a new CompletionFunc type.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)