Skip to content

waitExitOrRemoved: Handle context cancellation #5043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vvoland merged 1 commit into from
Apr 29, 2024
Merged

waitExitOrRemoved: Handle context cancellation #5043

vvoland merged 1 commit into from
Apr 29, 2024

Conversation

@vvoland
Copy link
Collaborator

@vvoland vvoland commented Apr 29, 2024 •
edited
Loading

Fix docker run printing an error.

$ docker run -d alpine sleep 3                                                                                                                                                                                                  
e28138819b6b32f8a5ce2adde83c6b08d2ea5c66ebc352f47cfb9283227f683f
ERRO[0002] error waiting for container: context canceled

Fix docker run -d ... printing an context canceled spurious error when OTEL is configured.

@vvoland
waitExitOrRemoved: Handle context cancellation
840016e 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added this to the 27.0.0 milestone Apr 29, 2024
@vvoland vvoland self-assigned this Apr 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 60.85%. Comparing base (9714adc) to head (840016e).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5043      +/-   ##
==========================================
- Coverage   61.08%   60.85%   -0.24%     
==========================================
  Files         295      295              
  Lines       20660    20840     +180     
==========================================
+ Hits        12621    12683      +62     
- Misses       7142     7251     +109     
- Partials      897      906       +9

@vvoland vvoland mentioned this pull request Apr 29, 2024
Merged
@vvoland vvoland merged commit e81b835 into docker:master Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neersighted neersighted neersighted approved these changes

@laurazard laurazard laurazard approved these changes

Assignees

@vvoland vvoland

Labels

kind/bugfix PR's that fix bugs process/cherry-picked

Projects

None yet

Milestone

27.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vvoland @codecov-commenter @neersighted @laurazard