docs: update host-gateway-ip to use daemon.json instead of cli flag#4818
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jan 23, 2024
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4818 +/- ##
==========================================
- Coverage 59.63% 59.22% -0.42%
==========================================
Files 287 285 -2
Lines 24777 24770 -7
==========================================
- Hits 14775 14669 -106
- Misses 9114 9213 +99
Partials 888 888 |
thaJeztah
reviewed
Jan 23, 2024
06b5db9 to
b82ce7d
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
b82ce7d to
ec0a624
Compare
thaJeztah
approved these changes
Jan 23, 2024
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
can you also open a cherry-pick for the 25.0 release branch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com
- What I did
Changes the host-gateway-ip example to use daemon.json config instead of cli flag.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)