opts: ValidateIPAddress: improve error, godoc, and tests#4657
Merged
thaJeztah merged 1 commit intodocker:masterfrom Nov 13, 2023
Merged
opts: ValidateIPAddress: improve error, godoc, and tests#4657thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
- document accepted values - add test-coverage for the function's behavior (including whitespace handling), and use sub-tests. - improve error-message to use uppercase for "IP", and to use a common prefix. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
7c48512 to
b0ee27d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4657 +/- ##
==========================================
- Coverage 59.74% 59.74% -0.01%
==========================================
Files 288 288
Lines 24849 24848 -1
==========================================
- Hits 14846 14845 -1
Misses 9117 9117
Partials 886 886 |
sam-thibault
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--add-hostoption #4648 (was looking at the code, because of that ticket)- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)