docker info: fix condition for printing debug information#4392
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jun 30, 2023
Merged
docker info: fix condition for printing debug information#4392thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
The daemon collects this information regardless if "debug" is enabled. Print the debugging information if either the daemon, or the client has debug enabled. We should probably improve this logic and print any of these if set (but some special rules are needed for file-descriptors, which may use "-1". Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4392 +/- ##
=======================================
Coverage 59.37% 59.38%
=======================================
Files 288 288
Lines 24746 24751 +5
=======================================
+ Hits 14693 14698 +5
Misses 9169 9169
Partials 884 884 |
neersighted
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
The daemon collects this information regardless if "debug" is enabled. Print the debugging information if either the daemon, or the client has debug enabled.
We should probably improve this logic and print any of these if set (but some special rules are needed for file-descriptors, which may use "-1".
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)