Handle empty DOCKER_BUILDKIT like unset#4216
Merged
thaJeztah merged 1 commit intodocker:masterfrom Apr 19, 2023
Merged
Conversation
This fixes the cli erroring out if the variable is set to an empty value. ``` $ export DOCKER_BUILDKIT= $ docker version DOCKER_BUILDKIT environment variable expects boolean value: strconv.ParseBool: parsing "": invalid syntax ``` Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4216 +/- ##
=======================================
Coverage 58.86% 58.86%
=======================================
Files 572 572
Lines 49544 49544
=======================================
Hits 29162 29162
Misses 18616 18616
Partials 1766 1766 |
Member
|
@crazy-max pal |
crazy-max
approved these changes
Apr 19, 2023
laurazard
approved these changes
Apr 19, 2023
Member
|
@vvoland can you open a cherry-pick as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the cli erroring out if the variable is set to an empty value.
The behavior for empty variable will be the same as if it was undefined.
- What I did
- How I did it
Use
os.Getenvinstead ofos.LookupEnv- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)