Skip to content

gha: align stray go 1.19.4 version#4138

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:fix_go_version
Mar 30, 2023
Merged

gha: align stray go 1.19.4 version#4138
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:fix_go_version

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

looks like this one was forgotten to be updated :)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

looks like this one was forgotten to be updated :)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@rumpl rumpl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many places this is defined... :)

@thaJeztah

Copy link
Copy Markdown
Member Author

So many places this is defined... :)

Yeah, we need to look at this; it was easier in the past where we had 1 or two GO_VERSION build-args (which is easier to grep for)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4138 (e443685) into master (fc6703b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4138   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         287      287           
  Lines       24716    24716           
=======================================
  Hits        14623    14623           
  Misses       9209     9209           
  Partials      884      884           

@thaJeztah thaJeztah merged commit 378e35e into docker:master Mar 30, 2023
@thaJeztah thaJeztah deleted the fix_go_version branch March 30, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants