Cli change to pass driver specific options to docker run #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @thaJeztah , @aaronlehmann |
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
==========================================
- Coverage 53.26% 53.18% -0.08%
==========================================
Files 258 258
Lines 16357 16391 +34
==========================================
+ Hits 8712 8718 +6
- Misses 7081 7106 +25
- Partials 564 567 +3 |
Member
|
Wondering; with this change, should we:
|
Member
|
ping @abhi this needs a rebase; also can you have a look at my comment above? |
The commit contains cli changes to support driver options for a network in docker run and docker network connect cli's. The driver-opt, aliases is now supported in the form of csv as per network option in service commands in swarm mode since docker#62 . This commit extends this support to docker run command as well. For docker connect command --driver-opt is added to pass driver specific options for the network the container is connecting to. Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
|
I wonder if this PR is in progress. |
Member
|
carried in #1767 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened this PR since #156 was closed.
The commit contains cli changes to support driver options for a network in docker run and docker network connect cli's.
The driver-opt, aliases is now supported in the form of csv as per network option in service commands in swarm mode since #62 . This commit extends this support to docker run command as well.
For docker connect command --driver-opt is added to pass driver specific options for the network the container is connecting to.
Following is supported:
Signed-off-by: Abhinandan Prativadi abhi@docker.com