Proposed Cluster (CSI) Volume Command#3129
Closed
dperny wants to merge 9 commits intodocker:masterfrom
Closed
Conversation
67ccbc2 to
5858b3e
Compare
Signed-off-by: Drew Erny <derny@mirantis.com>
Signed-off-by: Drew Erny <derny@mirantis.com>
Signed-off-by: Drew Erny <derny@mirantis.com>
Signed-off-by: Drew Erny <derny@mirantis.com>
Signed-off-by: Drew Erny <derny@mirantis.com>
Signed-off-by: Drew Erny <derny@mirantis.com>
5858b3e to
0357eac
Compare
Signed-off-by: Drew Erny <derny@mirantis.com>
Signed-off-by: Drew Erny <derny@mirantis.com>
Member
|
Did a rebase of this PR, and updated the references for the renamed structs/types; #3606 |
Member
|
closing this one as this was carried and merged in #3606 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a not fully functional draft proposal of the CLI for Swarm CSI Cluster Volumes.
This proposal involves merging the cluster volume specific options and commands with the existing volume subcommand. There are a handful of new create flags which are only applicable to cluster volumes. There is also a new flag for
list, which lists only cluster volumes and formats the table differently.Examples of the output can be found in the new
.goldenfiles.This PR does not build as-is, but instead is to show what a combined volumes command look like, in order to assess its ergonomics and UI.