printServerWarningsLegacy: silence "No kernel memory limit support"; silence "No oom kill disable support" on cgroup v2#3077
Merged
silvin-lubecki merged 2 commits intodocker:masterfrom May 18, 2021
Conversation
c43b745 to
58c85d3
Compare
The kernel memory limit is deprecated in Docker 20.10.0, and its support was removed in runc v1.0.0-rc94. So, this warning can be safely removed. Relevant: moby/moby@b8ca7de Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
…group v2 The warning should be ignored on cgroup v2 hosts. Relevant: moby/moby@8086443 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
58c85d3 to
204fad1
Compare
204fad1 to
05ec018
Compare
Member
|
I actually think it's a bug that we hit this code; instead of checking if the Warnings slice is empty, we should also skip this function based on API version used; cli/cli/command/system/info.go Line 381 in a32cd16 |
Collaborator
Author
Yes, but even when |
Member
|
@silvin-lubecki ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Removed unhandleable warnings from
printServerWarningsLegacy().- How I did it
These warnings have been already silenced on the daemon side.
- How to verify it
Before:
After: (no warning)