-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[WIP] reorganise reference docs #2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c3d039 to
1ce96cf
Compare
silvin-lubecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Please rebase @thaJeztah 🦁 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
doing in a separate commit to preserve history Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1ce96cf to
60e10f4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2389 +/- ##
==========================================
+ Coverage 57.15% 59.64% +2.49%
==========================================
Files 297 287 -10
Lines 18656 24771 +6115
==========================================
+ Hits 10662 14774 +4112
- Misses 7132 9111 +1979
- Partials 862 886 +24 |
| - `disconnect` | ||
| - `destroy` | ||
| - `disconnect` | ||
| - `remove` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that there's an extra remove here. Was that added intentionally?
58fa74e to
60e10f4
Compare
|
sorry, botched a rebase, looking at whether we could carry this one |
d2c14c2 to
60e10f4
Compare
Making sure there's only 1 canonical markdown file for each command. In the documentation repository, I'll add redirects for each command, and update titles to mention both variants.
e.g., redirect
docker buildtodocker image build