Skip to content

Conversation

@thaJeztah
Copy link
Member

Making sure there's only 1 canonical markdown file for each command. In the documentation repository, I'll add redirects for each command, and update titles to mention both variants.

e.g., redirect docker build to docker image build

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
Copy link
Contributor

Please rebase @thaJeztah 🦁

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
doing in a separate commit to preserve history

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #2389 (d2c14c2) into master (b4097f7) will increase coverage by 2.49%.
Report is 2170 commits behind head on master.
The diff coverage is 53.83%.

❗ Current head d2c14c2 differs from pull request most recent head 60e10f4. Consider uploading reports for the commit 60e10f4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2389      +/-   ##
==========================================
+ Coverage   57.15%   59.64%   +2.49%     
==========================================
  Files         297      287      -10     
  Lines       18656    24771    +6115     
==========================================
+ Hits        10662    14774    +4112     
- Misses       7132     9111    +1979     
- Partials      862      886      +24     

- `disconnect`
- `destroy`
- `disconnect`
- `remove`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that there's an extra remove here. Was that added intentionally?

@dvdksn dvdksn force-pushed the reference_canonical branch 2 times, most recently from 58fa74e to 60e10f4 Compare January 5, 2024 12:48
@dvdksn
Copy link
Contributor

dvdksn commented Jan 5, 2024

sorry, botched a rebase, looking at whether we could carry this one

@dvdksn dvdksn force-pushed the reference_canonical branch 2 times, most recently from d2c14c2 to 60e10f4 Compare January 5, 2024 13:26
@thaJeztah thaJeztah deleted the reference_canonical branch February 7, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants