Skip to content

bump google.golang.org/grpc v1.12.2#1811

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:bump_grpc_1.12.2
Apr 18, 2019
Merged

bump google.golang.org/grpc v1.12.2#1811
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:bump_grpc_1.12.2

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

full diff: grpc/grpc-go@v1.12.0...v1.12.2

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1811 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1811   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files         308      308           
  Lines       21391    21391           
=======================================
  Hits        12047    12047           
  Misses       8465     8465           
  Partials      879      879

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 6, 2019

Codecov Report

Merging #1811 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1811   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files         308      308           
  Lines       21610    21610           
=======================================
  Hits        12261    12261           
  Misses       8449     8449           
  Partials      900      900

@thaJeztah
Copy link
Copy Markdown
Member Author

ping @silvin-lubecki @vdemeester PTAL 🙏

@thaJeztah
Copy link
Copy Markdown
Member Author

(another update is likely coming, due to a possible panic in grpc)

Copy link
Copy Markdown
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

full diff: grpc/grpc-go@v1.12.0...v1.12.2

- grpc/grpc-go#2074 transport/server: fix race between writing status and header
  - fix grpc/grpc-go#1972 Possible race sending headers from server while receiving message over size limit
- grpc/grpc-go#2074 transport: account for user configured small io write buffer
  - fix grpc/grpc-go#2089 Server abruptly terminates connections if write buffer is small enough

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 438426e into docker:master Apr 18, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Apr 18, 2019
@thaJeztah thaJeztah deleted the bump_grpc_1.12.2 branch April 18, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants