Updated the go-winio library to release 0.4.8 that has the fix for Windows Container#1157
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jun 29, 2018
Merged
Updated the go-winio library to release 0.4.8 that has the fix for Windows Container#1157thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Contributor
Author
|
@GordonTheTurtle How do we investigate as to why the validate failed? |
Member
|
@mnltejaswini I believe you need to run |
Contributor
Author
|
Thank you @mat007 |
Member
|
all green now; looks like it needs a squash though 😅 - let me know if you need a hand with that |
…ndows containers Signed-off-by: Tejaswini Duggaraju <naduggar@microsoft.com>
mat007
approved these changes
Jun 29, 2018
thaJeztah
approved these changes
Jun 29, 2018
Member
thaJeztah
left a comment
There was a problem hiding this comment.
all green and squashed, thank you so much!
LGTM
Contributor
Author
|
@thaJeztah Thank you for merging. when can we expect the next release of the CLI, so we can use it |
Member
|
@mnltejaswini I opened cherry-pick PR's for 18.06, so will likely be in 18.06 RC2. For Docker EE, I expect it to be in the next 18.03 EE patch release. Don't have date for both 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
I updated the Microsoft/go-winio vendor package to 0.4.8 that has the bug fix release that adds support for pipe message read mode, allowing the pipe functionality to work inside Hyper-V-isolated Windows containers.
- How I did it
Updated the vendor.conf
- How to verify it
This should fix the moby/moby#36562 (comment)
- Description for the changelog
Updated the Microsoft/go-winio vendor package to 0.4.8 that has the bug fix release that adds support for pipe message read mode, allowing the pipe functionality to work inside Hyper-V-isolated Windows containers.
- A picture of a cute animal (not mandatory but encouraged)