Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v23.0.0-rc.2
Choose a base ref
...
head repository: docker/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v23.0.0-rc.3
Choose a head ref
  • 18 commits
  • 14 files changed
  • 6 contributors

Commits on Mar 4, 2021

  1. [completion/zsh] add volume completion

    This provides completion for `docker run ... -v <TAB>`.
    This closes (part of) #1997.
    
    Signed-off-by: Paul Seyfert <pseyfert.mathphys@gmail.com>
    pseyfert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    35b42ef View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. vendor: github.com/containerd/containerd v1.6.15

    no changes to vendored code
    
    full diff: https://github.com/conainerd/containerd/compare/v1.6.14...v1.6.15
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    0d16330 View commit details
    Browse the repository at this point in the history
  2. vendor: github.com/docker/docker v23.0.0-rc.2

    full diff: moby/moby@v23.0.0-rc.1...v23.0.0-rc.2
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c453cc6 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3963 from thaJeztah/engine_23.0_rc2

    vendor: github.com/docker/docker v23.0.0-rc.2
    thaJeztah authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f1f12a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Merge pull request #2998 from pseyfert/completion/zsh/volume

    [completion/zsh] add volume completion
    thaJeztah authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    1af9f22 View commit details
    Browse the repository at this point in the history
  2. docs: fix duplicated format anchor in plugin_ls

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    crazy-max committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    e04f3dd View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3966 from crazy-max/fix-docs-anchore

    docs: fix duplicated format anchor in plugin_ls
    thaJeztah authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    d0a4b6f View commit details
    Browse the repository at this point in the history
  4. README: fix badges

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    crazy-max committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    d347678 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. cli: pass dockerCLI's in/out/err to cobra cmds

    Both the DockerCLI and Cobra Commands provide accessors for Input, Output,
    and Error streams (usually STDIN, STDOUT, STDERR). While we were already
    passing DockerCLI's Output to Cobra, we were not doing so for the other
    streams (and were passing none for plugin commands), potentially resulting
    in DockerCLI output/input to mean something else than a Cobra Command's
    intput/output/error.
    
    This patch sets them to the same streams when constructing the Cobra
    command.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    fc6be6a View commit details
    Browse the repository at this point in the history
  2. cli: additionalHelp() don't decorate output if it's piped

    This prevents the escape-characters being included when piping the
    output, e.g. `docker --help > output.txt`, or `docker --help | something`.
    These control-characters could cause issues if users copy/pasted the URL
    from the output, resulting in them becoming part of the URL they tried
    to visit, which would fail, e.g. when copying the output from:
    
        To get more help with docker, check out our guides at https://docs.docker.com/go/guides/
    
    Users ended up on URLs like;
    
        https://docs.docker.com/go/guides/ESC
        https://docs.docker.com/go/guides/%1B[0m
    
    Before this patch, control characters ("bold") would be printed, even if
    no TTY was attached;
    
        docker --help > output.txt
        cat output.txt | grep 'For more help' | od -c
        0000000 033   [   1   m   F   o   r       m   o   r   e       h   e   l
        0000020   p       o   n       h   o   w       t   o       u   s   e
        0000040   D   o   c   k   e   r   ,       h   e   a   d       t   o
        0000060   h   t   t   p   s   :   /   /   d   o   c   s   .   d   o   c
        0000100   k   e   r   .   c   o   m   /   g   o   /   g   u   i   d   e
        0000120   s   / 033   [   0   m  \n
        0000127
    
        docker --help | grep 'For more help' | od -c
        0000000 033   [   1   m   F   o   r       m   o   r   e       h   e   l
        0000020   p       o   n       h   o   w       t   o       u   s   e
        0000040   D   o   c   k   e   r   ,       h   e   a   d       t   o
        0000060   h   t   t   p   s   :   /   /   d   o   c   s   .   d   o   c
        0000100   k   e   r   .   c   o   m   /   g   o   /   g   u   i   d   e
        0000120   s   / 033   [   0   m  \n
        0000127
    
    With this patch, no control characters are included:
    
        docker --help > output.txt
        cat output.txt | grep 'For more help' | od -c
        0000000   F   o   r       m   o   r   e       h   e   l   p       o   n
        0000020       h   o   w       t   o       u   s   e       D   o   c   k
        0000040   e   r   ,       h   e   a   d       t   o       h   t   t   p
        0000060   s   :   /   /   d   o   c   s   .   d   o   c   k   e   r   .
        0000100   c   o   m   /   g   o   /   g   u   i   d   e   s   /  \n
        0000117
    
        docker --help | grep 'For more help' | od -c
        0000000   F   o   r       m   o   r   e       h   e   l   p       o   n
        0000020       h   o   w       t   o       u   s   e       D   o   c   k
        0000040   e   r   ,       h   e   a   d       t   o       h   t   t   p
        0000060   s   :   /   /   d   o   c   s   .   d   o   c   k   e   r   .
        0000100   c   o   m   /   g   o   /   g   u   i   d   e   s   /  \n
        0000117
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    59e74b4 View commit details
    Browse the repository at this point in the history
  3. Add extra newline after additionalHelp output

    The additionalHelp message is printed at the end of the --help output;
    
        To get more help with docker, check out our guides at https://docs.docker.com/go/guides/
        PS>
    
    As this message may contain an URL, users may copy/paste the URL to open it
    in their browser, but can easily end up copying their prompt (as there's
    no whitespace after it), and as a result end up on a broken URL, for example:
    
        https://docs.docker.com/go/guides/PS
    
    This patch adds an extra newline at the end to provide some whitespace
    around the message, making it less error-prone to copy the URL;
    
        To get more help with docker, check out our guides at https://docs.docker.com/go/guides/
    
        PS>
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    9bb7021 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Merge pull request #3968 from crazy-max/fix-badges

    README: fix badges
    thaJeztah authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1493806 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3973 from thaJeztah/no_escape

    cli: additionalHelp() don't decorate output if it's piped, and add extra newline
    thaJeztah authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    fe694e8 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3971 from thaJeztah/sync_cobra_streams

    cli: pass dockerCLI's in/out/err to cobra cmds
    thaJeztah authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8627a6d View commit details
    Browse the repository at this point in the history
  4. note --user args usage restriction

    Signed-off-by: Yucheng Wu <wyc123wyc@gmail.com>
    yuchengwu authored and thaJeztah committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    5d04b1c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1900 from yuchengwu/8831-doc-user-restrict

    note `--user` args usage restriction
    thaJeztah authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f7c322e View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Fix section docker ps --size

    Remove the extra item "Size"
    
    Signed-off-by: Ali Rostami <rostami.ali@gmail.com>
    alirostami01 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    be30cb3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3977 from alirostami01/master

    Fix section docker ps --size
    thaJeztah authored Jan 18, 2023
    Configuration menu
    Copy the full SHA
    e1152b2 View commit details
    Browse the repository at this point in the history
Loading