-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Comparing changes
Open a pull request
base repository: docker/cli
base: v23.0.0-rc.2
head repository: docker/cli
compare: v23.0.0-rc.3
- 18 commits
- 14 files changed
- 6 contributors
Commits on Mar 4, 2021
-
[completion/zsh] add volume completion
This provides completion for `docker run ... -v <TAB>`. This closes (part of) #1997. Signed-off-by: Paul Seyfert <pseyfert.mathphys@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 35b42ef - Browse repository at this point
Copy the full SHA 35b42efView commit details
Commits on Jan 12, 2023
-
vendor: github.com/containerd/containerd v1.6.15
no changes to vendored code full diff: https://github.com/conainerd/containerd/compare/v1.6.14...v1.6.15 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 0d16330 - Browse repository at this point
Copy the full SHA 0d16330View commit details -
vendor: github.com/docker/docker v23.0.0-rc.2
full diff: moby/moby@v23.0.0-rc.1...v23.0.0-rc.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for c453cc6 - Browse repository at this point
Copy the full SHA c453cc6View commit details -
Merge pull request #3963 from thaJeztah/engine_23.0_rc2
vendor: github.com/docker/docker v23.0.0-rc.2
Configuration menu - View commit details
-
Copy full SHA for f1f12a3 - Browse repository at this point
Copy the full SHA f1f12a3View commit details
Commits on Jan 13, 2023
-
Merge pull request #2998 from pseyfert/completion/zsh/volume
[completion/zsh] add volume completion
Configuration menu - View commit details
-
Copy full SHA for 1af9f22 - Browse repository at this point
Copy the full SHA 1af9f22View commit details -
docs: fix duplicated format anchor in plugin_ls
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e04f3dd - Browse repository at this point
Copy the full SHA e04f3ddView commit details -
Merge pull request #3966 from crazy-max/fix-docs-anchore
docs: fix duplicated format anchor in plugin_ls
Configuration menu - View commit details
-
Copy full SHA for d0a4b6f - Browse repository at this point
Copy the full SHA d0a4b6fView commit details -
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d347678 - Browse repository at this point
Copy the full SHA d347678View commit details
Commits on Jan 15, 2023
-
cli: pass dockerCLI's in/out/err to cobra cmds
Both the DockerCLI and Cobra Commands provide accessors for Input, Output, and Error streams (usually STDIN, STDOUT, STDERR). While we were already passing DockerCLI's Output to Cobra, we were not doing so for the other streams (and were passing none for plugin commands), potentially resulting in DockerCLI output/input to mean something else than a Cobra Command's intput/output/error. This patch sets them to the same streams when constructing the Cobra command. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for fc6be6a - Browse repository at this point
Copy the full SHA fc6be6aView commit details -
cli: additionalHelp() don't decorate output if it's piped
This prevents the escape-characters being included when piping the output, e.g. `docker --help > output.txt`, or `docker --help | something`. These control-characters could cause issues if users copy/pasted the URL from the output, resulting in them becoming part of the URL they tried to visit, which would fail, e.g. when copying the output from: To get more help with docker, check out our guides at https://docs.docker.com/go/guides/ Users ended up on URLs like; https://docs.docker.com/go/guides/ESC https://docs.docker.com/go/guides/%1B[0m Before this patch, control characters ("bold") would be printed, even if no TTY was attached; docker --help > output.txt cat output.txt | grep 'For more help' | od -c 0000000 033 [ 1 m F o r m o r e h e l 0000020 p o n h o w t o u s e 0000040 D o c k e r , h e a d t o 0000060 h t t p s : / / d o c s . d o c 0000100 k e r . c o m / g o / g u i d e 0000120 s / 033 [ 0 m \n 0000127 docker --help | grep 'For more help' | od -c 0000000 033 [ 1 m F o r m o r e h e l 0000020 p o n h o w t o u s e 0000040 D o c k e r , h e a d t o 0000060 h t t p s : / / d o c s . d o c 0000100 k e r . c o m / g o / g u i d e 0000120 s / 033 [ 0 m \n 0000127 With this patch, no control characters are included: docker --help > output.txt cat output.txt | grep 'For more help' | od -c 0000000 F o r m o r e h e l p o n 0000020 h o w t o u s e D o c k 0000040 e r , h e a d t o h t t p 0000060 s : / / d o c s . d o c k e r . 0000100 c o m / g o / g u i d e s / \n 0000117 docker --help | grep 'For more help' | od -c 0000000 F o r m o r e h e l p o n 0000020 h o w t o u s e D o c k 0000040 e r , h e a d t o h t t p 0000060 s : / / d o c s . d o c k e r . 0000100 c o m / g o / g u i d e s / \n 0000117 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>Configuration menu - View commit details
-
Copy full SHA for 59e74b4 - Browse repository at this point
Copy the full SHA 59e74b4View commit details -
Add extra newline after additionalHelp output
The additionalHelp message is printed at the end of the --help output; To get more help with docker, check out our guides at https://docs.docker.com/go/guides/ PS> As this message may contain an URL, users may copy/paste the URL to open it in their browser, but can easily end up copying their prompt (as there's no whitespace after it), and as a result end up on a broken URL, for example: https://docs.docker.com/go/guides/PS This patch adds an extra newline at the end to provide some whitespace around the message, making it less error-prone to copy the URL; To get more help with docker, check out our guides at https://docs.docker.com/go/guides/ PS> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>Configuration menu - View commit details
-
Copy full SHA for 9bb7021 - Browse repository at this point
Copy the full SHA 9bb7021View commit details
Commits on Jan 17, 2023
-
Merge pull request #3968 from crazy-max/fix-badges
README: fix badges
Configuration menu - View commit details
-
Copy full SHA for 1493806 - Browse repository at this point
Copy the full SHA 1493806View commit details -
Merge pull request #3973 from thaJeztah/no_escape
cli: additionalHelp() don't decorate output if it's piped, and add extra newline
Configuration menu - View commit details
-
Copy full SHA for fe694e8 - Browse repository at this point
Copy the full SHA fe694e8View commit details -
Merge pull request #3971 from thaJeztah/sync_cobra_streams
cli: pass dockerCLI's in/out/err to cobra cmds
Configuration menu - View commit details
-
Copy full SHA for 8627a6d - Browse repository at this point
Copy the full SHA 8627a6dView commit details -
note
--userargs usage restrictionSigned-off-by: Yucheng Wu <wyc123wyc@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5d04b1c - Browse repository at this point
Copy the full SHA 5d04b1cView commit details -
Merge pull request #1900 from yuchengwu/8831-doc-user-restrict
note `--user` args usage restriction
Configuration menu - View commit details
-
Copy full SHA for f7c322e - Browse repository at this point
Copy the full SHA f7c322eView commit details
Commits on Jan 18, 2023
-
Remove the extra item "Size" Signed-off-by: Ali Rostami <rostami.ali@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be30cb3 - Browse repository at this point
Copy the full SHA be30cb3View commit details -
Merge pull request #3977 from alirostami01/master
Fix section docker ps --size
Configuration menu - View commit details
-
Copy full SHA for e1152b2 - Browse repository at this point
Copy the full SHA e1152b2View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v23.0.0-rc.2...v23.0.0-rc.3