ci: infer go version from workflow for bsd tests#2995
Merged
crazy-max merged 1 commit intodocker:masterfrom Feb 20, 2025
Merged
ci: infer go version from workflow for bsd tests#2995crazy-max merged 1 commit intodocker:masterfrom
crazy-max merged 1 commit intodocker:masterfrom
Conversation
Merged
AkihiroSuda
reviewed
Feb 19, 2025
| name: Prepare | ||
| run: | | ||
| echo "VAGRANT_FILE=hack/Vagrantfile.${{ matrix.os }}" >> $GITHUB_ENV | ||
| goVersion=$(curl --silent "https://go.dev/dl/?mode=json&include=all" | jq -r '.[].files[].version' | uniq | sed -e 's/go//' | sort -V | grep $GO_VERSION | tail -1) |
Collaborator
There was a problem hiding this comment.
Maybe this line should have a comment line to explain how the output differs from $GO_VERSION
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
bd7d634 to
cc0391e
Compare
AkihiroSuda
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be consistent with go version used in our workflows.