Skip to content

downgrade go-difflib and go-spew to tagged releases #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crazy-max merged 1 commit into from
Jan 15, 2025
Merged

downgrade go-difflib and go-spew to tagged releases #2921

crazy-max merged 1 commit into from
Jan 15, 2025

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 15, 2025

Unfortunately, for buildx, these popped back up through the kubernetes dependencies;

go mod graph | grep ' github.com/davecgh/go-spew@v1.1.2'
github.com/docker/buildx github.com/davecgh/go-spew@v1.1.2-0.20180830191138-d8f796af33cc
k8s.io/api@v0.31.2 github.com/davecgh/go-spew@v1.1.2-0.20180830191138-d8f796af33cc
k8s.io/apimachinery@v0.31.2 github.com/davecgh/go-spew@v1.1.2-0.20180830191138-d8f796af33cc
k8s.io/client-go@v0.31.2 github.com/davecgh/go-spew@v1.1.2-0.20180830191138-d8f796af33cc

@thaJeztah
downgrade go-difflib and go-spew to tagged releases
1ef9e67 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah self-assigned this Jan 15, 2025
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 15, 2025

Wait; why is CI failing? Let me cheeck

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 15, 2025

Looks some networking issue possibly;

> [lint-base 1/3] RUN wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.62.0:
0.060 Connecting to raw.githubusercontent.com (185.199.110.133:443)
0.089 writing to stdout
0.089 -                    100% |********************************| 11591  0:00:00 ETA
0.089 written to stdout
0.096 golangci/golangci-lint info checking GitHub for tag 'v1.62.0'
0.303 golangci/golangci-lint info found version: 1.62.0 for v1.62.0/linux/amd64
0.390 wget: error getting response: Resource temporarily unavailable

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 15, 2025

All green now 👍 was indeed a hiccup

@crazy-max crazy-max merged commit cde0e98 into docker:master Jan 15, 2025
127 checks passed
@thaJeztah thaJeztah deleted the downgrade_tagged_releases branch January 15, 2025 14:25
@thaJeztah thaJeztah mentioned this pull request Apr 17, 2025
Merged
@thaJeztah thaJeztah mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees

@thaJeztah thaJeztah

Labels

area/dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @crazy-max