[v0.10] cherry-picks for v0.10.4#1662
Merged
tonistiigi merged 2 commits intodocker:v0.10from Mar 6, 2023
Merged
Conversation
Member
crazy-max
commented
Mar 6, 2023
- build: makes git dirty check opt-in #1650
- docs: added --platform=local example #1584
Signed-off-by: David Karlsson <david.karlsson@docker.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
jedevc
approved these changes
Mar 6, 2023
thaJeztah
reviewed
Mar 6, 2023
|
|
||
| func TestGetGitAttributesDirty(t *testing.T) { | ||
| setupTest(t) | ||
| t.Setenv("BUILDX_GIT_CHECK_DIRTY", "true") |
Member
There was a problem hiding this comment.
@crazy-max do we have documentation for this env-var somewhere? (or is that outside of this repository?)
Member
Author
There was a problem hiding this comment.
Oh we need it in https://docs.docker.com/build/building/env-vars/ yeah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.