[0.10] Add env var to disable default attestations#1645
Merged
tonistiigi merged 1 commit intodocker:v0.10from Feb 22, 2023
Merged
[0.10] Add env var to disable default attestations#1645tonistiigi merged 1 commit intodocker:v0.10from
tonistiigi merged 1 commit intodocker:v0.10from
Conversation
For certain cases we need to build with `--provenance=false`. However not all build envs (especially in the OSS ethos) have the latest buildx so just blanket setting `--provenance=false` will fail in these cases. Having an env var allows people to set the value without having to worry about if the buildx version has the `--provenance` flag. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit bc9cb2c) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
tonistiigi
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For certain cases we need to build with
--provenance=false. However not all build envs (especially in the OSS ethos) have the latest buildx so just blanket setting--provenance=falsewill fail in these cases.Having an env var allows people to set the value without having to worry about if the buildx version has the
--provenanceflag.(cherry picked from commit bc9cb2c)