build: check reachable git commits#1592
Merged
crazy-max merged 2 commits intodocker:masterfrom Feb 8, 2023
Merged
Conversation
jedevc
approved these changes
Feb 3, 2023
tonistiigi
reviewed
Feb 7, 2023
9504f80 to
cf4f25b
Compare
thaJeztah
reviewed
Feb 7, 2023
cf4f25b to
fd0d31a
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
fd0d31a to
3ab04ce
Compare
jedevc
approved these changes
Feb 8, 2023
thaJeztah
approved these changes
Feb 8, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, but left some thoughts 😂
Comment on lines
+120
to
+121
| // Override the locale to ensure consistent output | ||
| cmd.Env = append(os.Environ(), "LC_ALL=C") |
Member
There was a problem hiding this comment.
Before I facepalm myself for not asking; did someone look (or do we need a tracking ticket) on the BuildKit side if we should also set this option there? (I think BuildKit also shells out to git - it may be in a more predictable environment, but possibly could still be a good thing to do)
Member
Author
There was a problem hiding this comment.
It might be useful on BuildKit too so we have a consistent output when users report issues.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3ab04ce to
fd58841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1587
We should check if the working tree has git commits before retrieving the git commit so it would not fail. I was also thinking of just silently fail. Let me know what sounds best.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com