Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Member
Author
|
This is ready now. PTAL @tiborvass @AkihiroSuda |
tiborvass
reviewed
Mar 26, 2019
| Meta map[string]interface{} | ||
| } | ||
|
|
||
| var drivers map[string]Factory |
Collaborator
There was a problem hiding this comment.
var drivers = map[string]Factory{}
Member
Author
There was a problem hiding this comment.
there is a nil check on line 34
Collaborator
There was a problem hiding this comment.
Hence my suggestion, so you can get rid of that :)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
27c28bb to
b3d7b5a
Compare
AkihiroSuda
reviewed
Mar 29, 2019
|
|
||
| conn = demuxConn(conn) | ||
|
|
||
| return client.New(ctx, "", client.WithDialer(func(string, time.Duration) (net.Conn, error) { |
Collaborator
There was a problem hiding this comment.
Just curious, why not use docker://... address?
This was referenced Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting to implement docker driver