Skip to content

setBreakpoints DAP response does not conform to the specification #3480

@rcjsuen

Description

@rcjsuen
github.com/docker/buildx v0.29.1-desktop.1 28f6246ff24e2c05095e8741e48c48dcb2d3b4bc

SetBreakpoints from the Debug Adapter Protocol specification:

To clear all breakpoint for a source, specify an empty array.

Given the following request...

{
    "command": "setBreakpoints",
    "seq": 3,
    "type": "request",
    "arguments": {
        "source": {
            "name": "Dockerfile",
            "path": "/Users/rcjsuen/tmp/buildx-debugging-demo/Dockerfile"
        },
        "breakpoints": []
    }
}

...I get this response back.

{
    "seq": 15,
    "type": "response",
    "request_seq": 3,
    "success": true,
    "command": "setBreakpoints",
    "body": {
        "breakpoints": null
    }
}

breakpoints should be an empty array []. Buildx should not be sending null back.

interface SetBreakpointsResponse extends Response {
  body: {
    /**
     * Information about the breakpoints.
     * The array elements are in the same order as the elements of the
     * `breakpoints` (or the deprecated `lines`) array in the arguments.
     */
    breakpoints: Breakpoint[];
  };
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions