Skip to content

Commit b4df085

Browse files
authored
Merge pull request #1930 from jedevc/revert-bc597e6b
2 parents f581942 + 5159571 commit b4df085

2 files changed

Lines changed: 10 additions & 11 deletions

File tree

bake/bake.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,12 +1048,12 @@ func toBuildOpt(t *Target, inp *Input) (*build.Options, error) {
10481048
bi.DockerfileInline = *t.DockerfileInline
10491049
}
10501050
updateContext(&bi, inp)
1051-
if strings.HasPrefix(bi.ContextPath, "cwd://") {
1052-
bi.ContextPath = path.Clean(strings.TrimPrefix(bi.ContextPath, "cwd://"))
1053-
}
10541051
if !build.IsRemoteURL(bi.ContextPath) && bi.ContextState == nil && !path.IsAbs(bi.DockerfilePath) {
10551052
bi.DockerfilePath = path.Join(bi.ContextPath, bi.DockerfilePath)
10561053
}
1054+
if strings.HasPrefix(bi.ContextPath, "cwd://") {
1055+
bi.ContextPath = path.Clean(strings.TrimPrefix(bi.ContextPath, "cwd://"))
1056+
}
10571057
for k, v := range bi.NamedContexts {
10581058
if strings.HasPrefix(v.Path, "cwd://") {
10591059
bi.NamedContexts[k] = build.NamedContext{Path: path.Clean(strings.TrimPrefix(v.Path, "cwd://"))}

bake/bake_test.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -386,19 +386,18 @@ func TestHCLCwdPrefix(t *testing.T) {
386386
m, g, err := ReadTargets(ctx, []File{fp}, []string{"app"}, nil, nil)
387387
require.NoError(t, err)
388388

389-
bo, err := TargetsToBuildOpt(m, &Input{})
390-
require.NoError(t, err)
389+
require.Equal(t, 1, len(m))
390+
_, ok := m["app"]
391+
require.True(t, ok)
391392

392-
require.Equal(t, 1, len(g))
393-
require.Equal(t, []string{"app"}, g["default"].Targets)
393+
_, err = TargetsToBuildOpt(m, &Input{})
394+
require.NoError(t, err)
394395

395-
require.Equal(t, 1, len(m))
396-
require.Contains(t, m, "app")
397396
require.Equal(t, "test", *m["app"].Dockerfile)
398397
require.Equal(t, "foo", *m["app"].Context)
399398

400-
require.Equal(t, "foo/test", bo["app"].Inputs.DockerfilePath)
401-
require.Equal(t, "foo", bo["app"].Inputs.ContextPath)
399+
require.Equal(t, 1, len(g))
400+
require.Equal(t, []string{"app"}, g["default"].Targets)
402401
}
403402

404403
func TestOverrideMerge(t *testing.T) {

0 commit comments

Comments
 (0)