Conversation
.github/SECURITY.md
Outdated
| [security@docker.com](mailto:security@docker.com). | ||
|
|
||
| Security reports are greatly appreciated, and we will publicly thank you for it. | ||
| We also like to send gifts—if you're into schwag, make sure to let |
There was a problem hiding this comment.
| We also like to send gifts—if you're into schwag, make sure to let | |
| We also like to send gifts—if you'd like Docker swag, make sure to let |
There was a problem hiding this comment.
Copied this one from https://github.com/docker/buildx/blob/master/.github/SECURITY.md but I think we also have it on other docker repos.
Maybe it would be worth to have a org-wide .github repo and put the SECURITY.md in it so it can be used by all repos across the org? https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file#about-default-community-health-files
There was a problem hiding this comment.
Yeah I figured it was copied from somewhere. Agree that we should probably have an org-wide thing. You can keep the original text if you want, I just thought it was kind of cringe. I'll add the question about an org-wide .github repo to my backlog to investigate.
There was a problem hiding this comment.
Heh same issue in lots of places: https://github.com/moby/buildkit/blob/master/.github/SECURITY.md.
3cc18f1 to
2b51da9
Compare
.github/CODE_OF_CONDUCT.md
Outdated
| # Code of conduct | ||
|
|
||
| - [Moby community guidelines](https://github.com/moby/moby/blob/master/CONTRIBUTING.md#moby-community-guidelines) | ||
| - [Docker Code of Conduct](https://github.com/docker/code-of-conduct) |
There was a problem hiding this comment.
Hm. This repo doesn't seem to be actively updated/maintained, is this still the right thing to point to?
I'd be happy to just point to moby/moby for this.
There was a problem hiding this comment.
Yeah indeed 😞 I just used the one from buildx repo. We should review that in follow-up. Removing for now.
There was a problem hiding this comment.
super nit picky idea 🤔
Could we potentially have a make generated-files or similar that generates these markdown files by pulling from buildx? Then we only need to maintain those in one place.
There was a problem hiding this comment.
I think a org-wide .github would be better, see #931 (comment)
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2b51da9 to
12a9f89
Compare
Align community files.