Skip to content

preserve trailing whitespace in secrets input#1538

Merged
tonistiigi merged 2 commits into
docker:masterfrom
crazy-max:secrets-no-trim
May 26, 2026
Merged

preserve trailing whitespace in secrets input#1538
tonistiigi merged 2 commits into
docker:masterfrom
crazy-max:secrets-no-trim

Conversation

@crazy-max

@crazy-max crazy-max commented May 22, 2026

Copy link
Copy Markdown
Member

fixes #1242

The shared toolkit should keep trimming input lists by default for compatibility, but secret values are byte-sensitive and should not be normalized by the action before they are written to the temporary secret file.

crazy-max added 2 commits May 22, 2026 17:43
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from tonistiigi May 22, 2026 15:46
@crazy-max crazy-max marked this pull request as ready for review May 22, 2026 15:46
@tonistiigi tonistiigi merged commit d4bf874 into docker:master May 26, 2026
73 checks passed
@crazy-max crazy-max deleted the secrets-no-trim branch May 26, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Whitespace trimmed from multi-line secrets input

2 participants