docker(install): opt to expose local tcp address#531
Merged
crazy-max merged 3 commits intodocker:mainfrom Dec 12, 2024
Merged
Conversation
3476a96 to
5b9555f
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
db19a10 to
f0cc1b8
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
d8b99ff to
56f7596
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
56f7596 to
51e6621
Compare
vvoland
reviewed
Dec 13, 2024
| const cmd = `${dockerPath} --host="${dockerHost}" --config-file="${daemonConfigPath}" --exec-root="${this.runDir}/execroot" --data-root="${this.runDir}/data" --pidfile="${this.runDir}/docker.pid"`; | ||
| let cmd = `${dockerPath} --host="${dockerHost}" --config-file="${daemonConfigPath}" --exec-root="${this.runDir}/execroot" --data-root="${this.runDir}/data" --pidfile="${this.runDir}/docker.pid"`; | ||
| if (this.localTCPPort) { | ||
| cmd += ` --host="tcp://127.0.0.1:${this.localTCPPort}"`; |
Contributor
There was a problem hiding this comment.
Note: Exposing the docker socket over TCP without TLS is deprecated and will be a hard failure in future:
WARN[2024-12-13T11:24:36.737970212Z] Binding to IP address without --tlsverify is insecure and gives root access on this machine to everyone who has access to your network. host="tcp://127.0.0.1:1234"
WARN[2024-12-13T11:24:36.738007253Z] Binding to an IP address, even on localhost, can also give access to scripts run in a browser. Be safe out there! host="tcp://127.0.0.1:1234"
WARN[2024-12-13T11:24:36.738011878Z] [DEPRECATION NOTICE] In future versions this will be a hard failure preventing the daemon from starting! Learn more at: https://docs.docker.com/go/api-security/ host="tcp://127.0.0.1:1234"
See: moby/moby#41285
Member
Author
There was a problem hiding this comment.
I do agree but hope there will be some opt-in env var to still avoid TLS for development purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be used in https://github.com/docker/setup-docker-action