bake: support composable attributes #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa2455e to
733f698
Compare
733f698 to
8c24017
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
8c24017 to
068b0dc
Compare
jsternberg
approved these changes
Jan 7, 2025
Contributor
jsternberg
left a comment
There was a problem hiding this comment.
Looks good. I just had one question. I wanted to make sure that mixing the two styles worked correctly.
| // convert to composable attributes: https://github.com/docker/buildx/pull/2758 | ||
| for (const name in definition.target) { | ||
| const target = definition.target[name]; | ||
| if (target['cache-from'] && Array.isArray(target['cache-from'])) { |
Contributor
There was a problem hiding this comment.
I think this means that you can mix the csv style with the composable style but I just wanted to make sure I was reading this right.
Member
Author
There was a problem hiding this comment.
It means we always want composable attributes so if csv values are passed we convert them to composable attributes.
Member
Author
|
I'm merging this one and will open a follow-up to handle attestations related to docker/buildx#2848. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #503
This adds support for composable attributes with backward compatibility for csv syntax.