docker/install: Fix latest image install on lima#480
Merged
crazy-max merged 1 commit intodocker:mainfrom Oct 30, 2024
Merged
Conversation
Member
leads to 404: https://raw.githubusercontent.com/moby/moby/27.3.1/contrib/init/systemd/docker.service Looks like commit sha is not resolved and |
946f9ec to
5898099
Compare
Contributor
Author
|
EDIT: The url is correct, but for some reason the gitCommit isn't set. Looking into it. |
crazy-max
reviewed
Oct 30, 2024
src/docker/install.ts
Outdated
Comment on lines
+145
to
+146
| const manifest = await moby.getPlatformManifest(tag); | ||
| const config = await moby.getConfig<ImageConfig>(manifest.config.digest); |
Member
There was a problem hiding this comment.
I think labels and annotations will only be on the manifest list (index) config
Contributor
Author
There was a problem hiding this comment.
Looking at docker buildx imagetools inspect moby/moby-bin:latest --raw , index doesn't have these:
{
"schemaVersion": 2,
"mediaType": "application/vnd.oci.image.index.v1+json",
"manifests": [
{
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"digest": "sha256:c52ff4ad684b729f597eefacf1abc65913dcb3423071b71997cd271690c8a9b7",
"size": 1630,
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
{
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"digest": "sha256:fda20c7387897ee54811fd74b96472c4a454a62f29b5eb595caaeb4e04f01bd5",
"size": 567,
"annotations": {
"vnd.docker.reference.digest": "sha256:c52ff4ad684b729f597eefacf1abc65913dcb3423071b71997cd271690c8a9b7",
"vnd.docker.reference.type": "attestation-manifest"
},
"platform": {
"architecture": "unknown",
"os": "unknown"
}
...
Contributor
Author
There was a problem hiding this comment.
The image config has them though:
docker buildx imagetools inspect moby/moby-bin:latest@sha256:fe77a2f844e3db621de180b88e0e8c5439dd6802e4e6efcc5371be4a05e252d3 --raw | jq
{
"architecture": "amd64",
"config": {
"Env": [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
],
"WorkingDir": "/",
"Labels": {
"org.opencontainers.image.created": "2024-09-20T18:10:20.768Z",
"org.opencontainers.image.description": "The Moby Project - a collaborative project for the container ecosystem to assemble container-based systems",
"org.opencontainers.image.licenses": "Apache-2.0",
"org.opencontainers.image.revision": "41ca978a0a5400cc24b274137efa9f25517fcc0b",
"org.opencontainers.image.source": "https://github.com/moby/moby",
"org.opencontainers.image.title": "moby",
"org.opencontainers.image.url": "https://github.com/moby/moby",
"org.opencontainers.image.version": "27.3.1"
}
},5898099 to
82cd3fd
Compare
Contributor
Author
|
Drafted for now and added some debug logs. Will undraft once fixed. |
8c34034 to
c1a54eb
Compare
Contributor
Author
|
Fixed! The issues were:
|
crazy-max
reviewed
Oct 30, 2024
`latest` is not a valid git tag or revision to get the matching systemd unit files. Look up the exact source git commit from the `'org.opencontainers.image.revision` image config label. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
c1a54eb to
61c10b2
Compare
crazy-max
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latestis not a valid git tag or revision to get the matching systemd unit files.Look up the exact source git commit from the
org.opencontainers.image.revisionimage config label.