Skip to content

buildx(build): resolveCacheToAttrs func#350

Merged
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:gha-rest
Jun 10, 2024
Merged

buildx(build): resolveCacheToAttrs func#350
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:gha-rest

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jun 5, 2024

follow-up moby/buildkit#4788 (review)

When using gha cache export type, set repository and ghtoken attributes.

Needs follow-up on build-push-action and bake-action to use this func.

@crazy-max
buildx(build): resolveCacheToAttrs func
15788e8 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from tonistiigi June 5, 2024 12:44
@crazy-max crazy-max marked this pull request as ready for review June 5, 2024 12:44
@crazy-max crazy-max mentioned this pull request Jun 7, 2024
Merged
@crazy-max crazy-max merged commit 33d4b44 into docker:main Jun 10, 2024
@crazy-max crazy-max deleted the gha-rest branch June 10, 2024 11:39
@crazy-max crazy-max mentioned this pull request Jun 10, 2024
Merged
@crazy-max
Copy link
Member Author

crazy-max commented Jun 10, 2024

For bake-action that's tricky. We need to first load the definition to check cache-to usage in targets and would then need to use overrides to correct them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@crazy-max