Skip to content

util: comment opt for getInputList#115

Merged
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:input-comment-opt
Jun 13, 2023
Merged

util: comment opt for getInputList#115
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:input-comment-opt

Conversation

@crazy-max
Copy link
Member

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from jedevc June 9, 2023 12:13
@crazy-max

This comment was marked as outdated.

@crazy-max
Copy link
Member Author

crazy-max commented Jun 12, 2023

Looks like we need this change for the build push action: docker/build-push-action#879. The bake action already has support for comments but making it enabled by default in the toolkit introduced a breaking change.

PTAL @jedevc

Copy link

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants