Codecov Report

Merging #403 (348ebb7) into main (21084e2) will increase coverage by 0.00%.
The diff coverage is 88.23%.

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         134      134           
  Lines        6516     6561   +45     
=======================================
+ Hits         5646     5685   +39     
- Misses        870      876    +6     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21084e2...348ebb7. Read the comment docs.

I am considering the following changes to nomenclature:
secondary_index -> subindex
secondary_indices_configs -> subindex_configs
da.find(query=..., secondary_index='@.[image]') -> da.find(query=..., find_on='@.[image]')

Technically, secondary_index is probably more correct than subindex, but I much prefer the brevity.

Also related to this: with this nomenclature on find() we could enable the same syntax on in-memory-DA without causing confusion. It would unify the experience between in-memory and document store.

The implementation could be as simple as this, since no actual secondary index is needed:

def find(self, ..., find_on=None):
    if find_on:
        return self[find_on].find(...)

Continued here: #456