Skip to content

Conversation

@JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 25, 2023

Goals:

Add filtering capability with the same QueryLanguage as in v1 docarray.

TODO:

  • Implement the operators in every Document Type
  • Test

Jackmin801 and others added 15 commits January 26, 2023 18:33
#1026)

* test: add tensor ops tests

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>

* feat: instances of parametrized types are not parametrized anymore

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>

* test: fix test that have been changed by this feature

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>

* refactor: change class name and add comments

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>

* test: add tests to make sure isinstance does not do coercion

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>

* fix: parametrized isinstance check should not perform coercion

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>

* test: add more tests to parametrized class name tests

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>

* style: small black fix

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
* feat: add rich display for doc and da

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: wip plot

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: wip plot

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: wip plot

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* feat: add math package and minmax normalize

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: summary for document

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* chore: update poetry lock after rebase

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: move all from plotmixin to base document

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* feat: add docs schema summary

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* feat: add document array summary

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: display doc within doc

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: in notebook print docs summary

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: move summary from da to abstract da

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: get schema for doc

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: wip doc summary

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: wip clean up

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* test: add test for da pretty print

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* docs: update note

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* docs: add some documentation

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: apply samis suggestion

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: mypy checks

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: move to plot mixin

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: remove redundant line

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: remove comments

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* feat: add schema highlighter

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: add plotmixin to mixin init

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: adjust da summary

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: move minmaxnormalize to comp backend

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: remove redundant lines

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: add squeeze and detach to comp backend

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: apply suggestion from code review

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* refactor: rename iterable attrs

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: clean up

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: import

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: iterate over fields instead of annotations

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: remove math package since moved to comp backends

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* refactor: use single quotes

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: apply suggestions from code review

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: extract summary to doc summary class

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: add pretty print for base document

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: use rich capture instead of string io

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: add colors for optional and union and use only single quotes

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: extract display classes to display package

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: make da not optional in da summary

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: set _console instead of initializing new one everytime in __str__

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

* fix: put console at module level

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
* feat: add python 3.7 support

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>

* feat: remove get args

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>

* fix: fix

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>

* fix: fix

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>

* chore(ci): bump ci

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM JoanFM marked this pull request as ready for review January 27, 2023 10:51
@JoanFM JoanFM requested a review from samsja January 27, 2023 10:52
Joan Fontanals Martinez added 2 commits January 27, 2023 12:02
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@github-actions
Copy link

📝 Docs are deployed on https://ft-v2-filter--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit f870b87 into feat-rewrite-v2 Jan 27, 2023
@JoanFM JoanFM deleted the v2-filter branch January 27, 2023 13:36
This was referenced Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants