-
Notifications
You must be signed in to change notification settings - Fork 234
feat: add filter capability to DocumentArray #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f76d828 to
71aee07
Compare
#1026) * test: add tensor ops tests Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * feat: instances of parametrized types are not parametrized anymore Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * test: fix test that have been changed by this feature Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * refactor: change class name and add comments Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * test: add tests to make sure isinstance does not do coercion Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * fix: parametrized isinstance check should not perform coercion Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * test: add more tests to parametrized class name tests Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * style: small black fix Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
* feat: add rich display for doc and da Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: wip plot Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: wip plot Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: wip plot Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * feat: add math package and minmax normalize Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: summary for document Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * chore: update poetry lock after rebase Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: move all from plotmixin to base document Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * feat: add docs schema summary Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * feat: add document array summary Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: display doc within doc Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: in notebook print docs summary Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: move summary from da to abstract da Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: get schema for doc Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: wip doc summary Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: wip clean up Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * test: add test for da pretty print Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: update note Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: add some documentation Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: apply samis suggestion Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: mypy checks Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: move to plot mixin Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: remove redundant line Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: remove comments Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * feat: add schema highlighter Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: add plotmixin to mixin init Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: adjust da summary Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: move minmaxnormalize to comp backend Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: remove redundant lines Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: add squeeze and detach to comp backend Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: apply suggestion from code review Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * refactor: rename iterable attrs Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: clean up Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: import Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: iterate over fields instead of annotations Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: remove math package since moved to comp backends Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * refactor: use single quotes Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: apply suggestions from code review Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: extract summary to doc summary class Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: add pretty print for base document Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: use rich capture instead of string io Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: add colors for optional and union and use only single quotes Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: extract display classes to display package Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: make da not optional in da summary Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: set _console instead of initializing new one everytime in __str__ Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: put console at module level Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
* feat: add python 3.7 support Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: remove get args Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * chore(ci): bump ci Signed-off-by: samsja <sami.jaghouar@hotmail.fr> Signed-off-by: samsja <sami.jaghouar@hotmail.fr> Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JohannesMessner
requested changes
Jan 27, 2023
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
samsja
reviewed
Jan 27, 2023
samsja
reviewed
Jan 27, 2023
samsja
reviewed
Jan 27, 2023
samsja
reviewed
Jan 27, 2023
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JohannesMessner
approved these changes
Jan 27, 2023
|
📝 Docs are deployed on https://ft-v2-filter--jina-docs.netlify.app 🎉 |
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
Add filtering capability with the same QueryLanguage as in v1 docarray.
TODO:
operatorsin every Document Type