Set Era Payout Damping Factor Proposal mappings#13
Closed
thesan wants to merge 23 commits intodobertRowneySr:luxor/reward-curve-proposalfrom
Closed
Set Era Payout Damping Factor Proposal mappings#13thesan wants to merge 23 commits intodobertRowneySr:luxor/reward-curve-proposalfrom
thesan wants to merge 23 commits intodobertRowneySr:luxor/reward-curve-proposalfrom
Conversation
zeeshanakram3
left a comment
There was a problem hiding this comment.
Looks Good, just added a couple of comments, I will have another review iteration once PR is created on monorepo.
|
|
||
| type SetEraPayoutDampingFactorProposalDetails @variant { | ||
| "Proposed validator payout damping factor" | ||
| dampingFactor: Int! |
There was a problem hiding this comment.
Isn't Float a better type of damping factor?
Suggested change
| dampingFactor: Int! | |
| dampingFactor: Float! |
Author
There was a problem hiding this comment.
I thought the Percent type was an integer (and for more precision Permill, Perbill, ... where used). Can the Percent value be a decimal ? Or is there a different reason why it should be a Float ?
7ae799c to
bcf1a3f
Compare
…e-proposal Luxor/reward-curve-proposal
Add proxy pallet
mention pre-condition that revenue split is not active
…while-revenue-split Amm buy/sell operations not allowed during revenue split
…-proposal-qn [QN] CRT constraints proposal support
…g-qn Add vested budget spending tests and mappings
bcf1a3f to
5acfe25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Joystream#5113
Important
As I mentioned here: Joystream#5086 (comment) these mappings are based on Joystream@506bdcd. The latest commit: Joystream@92e1d1a breaks them.