Ephemeral port#25
Closed
ibauersachs wants to merge 1 commit into
Closed
Conversation
kentros
reviewed
May 18, 2019
| bind_random((InetSocketAddress) addr); | ||
| if (bound) | ||
| return; | ||
| boolean useEphemeralPort = Boolean.parseBoolean(System.getProperty(UDPCLIENT_DEFAULT_TO_EPHEMERAL_PORT, "false")); |
Contributor
There was a problem hiding this comment.
nit: parseBoolean was introduced in Java 1.5. Is there a plan to go forward with bumping the minimum target?
Member
Author
There was a problem hiding this comment.
This is just a backup of a patch from Sourceforge. But yes, I'll update the target to 1.5 as the code already uses some 1.5 stuff.
9d48887 to
5613413
Compare
kentros
approved these changes
May 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.