Skip to content

Pin actions in workflows using commit SHA#7121

Merged
mitchelsellers merged 2 commits intodevelopfrom
github-actions-sha-pin
Mar 17, 2026
Merged

Pin actions in workflows using commit SHA#7121
mitchelsellers merged 2 commits intodevelopfrom
github-actions-sha-pin

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented Mar 17, 2026

Summary

When pulling in actions in GitHub Actions workflows, use the full commit SHA to identify the action version, instead of a tag name which can be moved if the account is compromised.

@bdukes bdukes added this to the 10.2.4 milestone Mar 17, 2026
@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Mar 17, 2026

Once this is setup, we can configure GitHub Actions to require a commit SHA:
image

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

    1 files  ±0      1 suites  ±0   1m 14s ⏱️ -6s
2 524 tests ±0  2 512 ✅ ±0  12 💤 ±0  0 ❌ ±0 
2 847 runs  ±0  2 835 ✅ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit c212fe5. ± Comparison against base commit fbf12ce.

This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both.
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ar_JO("",-1,03/17/2026 15:04:07,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ar_JO("lorem ipsum",456,03/17/2026 15:04:07,-15:04:07.7016735)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ca_ES("",-1,03/17/2026 15:04:07,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ca_ES("lorem ipsum",456,03/17/2026 15:04:07,-15:04:07.7016735)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_en_US("",-1,03/17/2026 15:04:07,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_en_US("lorem ipsum",456,03/17/2026 15:04:07,-15:04:07.7016735)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_fr_FR("",-1,03/17/2026 15:04:07,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_fr_FR("lorem ipsum",456,03/17/2026 15:04:07,-15:04:07.7016735)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_he_IL("",-1,03/17/2026 15:04:07,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_he_IL("lorem ipsum",456,03/17/2026 15:04:07,-15:04:07.7016735)
…
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ar_JO("",-1,03/17/2026 18:21:47,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ar_JO("lorem ipsum",456,03/17/2026 18:21:47,-18:21:47.7625481)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ca_ES("",-1,03/17/2026 18:21:47,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ca_ES("lorem ipsum",456,03/17/2026 18:21:47,-18:21:47.7625481)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_en_US("",-1,03/17/2026 18:21:47,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_en_US("lorem ipsum",456,03/17/2026 18:21:47,-18:21:47.7625481)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_fr_FR("",-1,03/17/2026 18:21:47,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_fr_FR("lorem ipsum",456,03/17/2026 18:21:47,-18:21:47.7625481)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_he_IL("",-1,03/17/2026 18:21:47,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_he_IL("lorem ipsum",456,03/17/2026 18:21:47,-18:21:47.7625481)
…

@mitchelsellers mitchelsellers merged commit d40a398 into develop Mar 17, 2026
5 checks passed
@mitchelsellers mitchelsellers deleted the github-actions-sha-pin branch March 17, 2026 19:54
@valadas valadas modified the milestones: 10.2.4, 10.3.0 Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants