Skip to content

Update env variables from workflow_dispatch inputs#7120

Merged
valadas merged 1 commit intodevelopfrom
github-actions-fix-manual-inputs
Mar 17, 2026
Merged

Update env variables from workflow_dispatch inputs#7120
valadas merged 1 commit intodevelopfrom
github-actions-fix-manual-inputs

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented Mar 17, 2026

GitHub Actions allows defining inputs when manually triggering a build. However, these values are available only via the inputs context, which does not exist when the workflow runs due to another trigger.

Specifically, this meant that our current workflow does not actually use the manual input, only the defaults, since it just looks in the env context, instead of the inputs context.

Therefore, this PR adds a new step to update the env context with either the inputs value or the default.

Based on https://github.com/orgs/community/discussions/26322#discussioncomment-11553893

@bdukes bdukes added this to the 10.2.4 milestone Mar 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

Test Results

    1 files  ±0      1 suites  ±0   1m 22s ⏱️ +8s
2 524 tests ±0  2 512 ✅ ±0  12 💤 ±0  0 ❌ ±0 
2 847 runs  ±0  2 835 ✅ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 625a353. ± Comparison against base commit 19f7aa4.

This pull request removes 80 and adds 80 tests. Note that renamed tests count towards both. 
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ar_JO("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ca_ES("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_en_US("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_fr_FR("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_he_IL("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ru_RU("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_tr_TR("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_zh_CN("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ SaveSettings_CallsUpdateModuleSetting_WithRightParameters_ar_JO("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ SaveSettings_CallsUpdateModuleSetting_WithRightParameters_ca_ES("Bsskk41233[]#%&",-5,-13456.456d,True,03/15/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
…

DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ar_JO("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ca_ES("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_en_US("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_fr_FR("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_he_IL("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ru_RU("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_tr_TR("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_zh_CN("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ SaveSettings_CallsUpdateModuleSetting_WithRightParameters_ar_JO("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ SaveSettings_CallsUpdateModuleSetting_WithRightParameters_ca_ES("Bsskk41233[]#%&",-5,-13456.456d,True,03/16/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
…

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Mar 17, 2026

This is a release management task, as per our policy, we are self-approving it.

@valadas valadas merged commit fbf12ce into develop Mar 17, 2026
5 of 6 checks passed
@valadas valadas deleted the github-actions-fix-manual-inputs branch March 17, 2026 14:54
@valadas valadas modified the milestones: 10.2.4, 10.3.0 Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Type: Build/Release

Projects

None yet

Milestone

10.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bdukes @valadas