Skip to content

Add GitHub Actions job to deploy to NuGet#7117

Merged
bdukes merged 1 commit intodevelopfrom
github-actions-nuget-deploy
Mar 18, 2026
Merged

Add GitHub Actions job to deploy to NuGet#7117
bdukes merged 1 commit intodevelopfrom
github-actions-nuget-deploy

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented Mar 16, 2026

Summary

This PR adds a second job to the GitHub Actions workflow for CI. It only runs when the build is manually triggered, and it uses an environment to gate its running until approved. It's setup to use NuGet Trusted Publishing, which still needs to be setup on the NuGet side (currently configured to use MitchelSellers as the NuGet user via an environment secret).

Alternatives Considered

Instead of tacking this on to the end of each CI request, it could be a separate workflow that builds everything again (maybe triggered on creating a release), or a manual workflow that requires specifying an artifact ID.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 16, 2026

Test Results

    1 files  ±0      1 suites  ±0   1m 16s ⏱️ ±0s
2 524 tests ±0  2 512 ✅ ±0  12 💤 ±0  0 ❌ ±0 
2 847 runs  ±0  2 835 ✅ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 4b1a9e0. ± Comparison against base commit d40a398.

This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both.
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ar_JO("",-1,03/17/2026 20:03:48,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ar_JO("lorem ipsum",456,03/17/2026 20:03:48,-20:03:48.1541618)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ca_ES("",-1,03/17/2026 20:03:48,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ca_ES("lorem ipsum",456,03/17/2026 20:03:48,-20:03:48.1541618)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_en_US("",-1,03/17/2026 20:03:48,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_en_US("lorem ipsum",456,03/17/2026 20:03:48,-20:03:48.1541618)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_fr_FR("",-1,03/17/2026 20:03:48,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_fr_FR("lorem ipsum",456,03/17/2026 20:03:48,-20:03:48.1541618)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_he_IL("",-1,03/17/2026 20:03:48,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_he_IL("lorem ipsum",456,03/17/2026 20:03:48,-20:03:48.1541618)
…
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ar_JO("",-1,03/17/2026 20:39:13,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ar_JO("lorem ipsum",456,03/17/2026 20:39:13,-20:39:13.7737526)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ca_ES("",-1,03/17/2026 20:39:13,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_ca_ES("lorem ipsum",456,03/17/2026 20:39:13,-20:39:13.7737526)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_en_US("",-1,03/17/2026 20:39:13,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_en_US("lorem ipsum",456,03/17/2026 20:39:13,-20:39:13.7737526)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_fr_FR("",-1,03/17/2026 20:39:13,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_fr_FR("lorem ipsum",456,03/17/2026 20:39:13,-20:39:13.7737526)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_he_IL("",-1,03/17/2026 20:39:13,00:53:35.6480000)
DotNetNuke.Tests.Core.Entities.Modules.Settings.NullableSettingsTests ‑ GetSettings_GetsValues_FromCorrectSettings_he_IL("lorem ipsum",456,03/17/2026 20:39:13,-20:39:13.7737526)
…

♻️ This comment has been updated with latest results.

@bdukes bdukes added this to the 10.2.4 milestone Mar 17, 2026
@valadas
Copy link
Copy Markdown
Contributor

valadas commented Mar 17, 2026

@bdukes I did setup Nuget for trusted publishing, we can discuss in todays meeting...

@bdukes bdukes force-pushed the github-actions-nuget-deploy branch from 37e1a98 to c962041 Compare March 17, 2026 18:32
@bdukes bdukes force-pushed the github-actions-nuget-deploy branch from c962041 to 4b1a9e0 Compare March 17, 2026 20:04
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is this ready to merge @bdukes or you needed to fix something regarding versioning?

@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Mar 18, 2026

It's ready, the version issue is only on the feature/bulk-install branch.

@bdukes bdukes merged commit 22a947f into develop Mar 18, 2026
7 checks passed
@bdukes bdukes deleted the github-actions-nuget-deploy branch March 18, 2026 13:18
@valadas valadas modified the milestones: 10.2.4, 10.3.0 Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants