Fix the addition of assemblies and sql scripts to module build#7098
Merged
valadas merged 3 commits intodnnsoftware:developfrom Mar 9, 2026
Merged
Fix the addition of assemblies and sql scripts to module build#7098valadas merged 3 commits intodnnsoftware:developfrom
valadas merged 3 commits intodnnsoftware:developfrom
Conversation
bdukes
approved these changes
Mar 9, 2026
bdukes
requested changes
Mar 9, 2026
Contributor
bdukes
left a comment
There was a problem hiding this comment.
This added a dll to the root of the package, it didn't put it in a bin folder in the zip
201f3fe to
ce266ec
Compare
Contributor
|
I've pushed a fix which accounts for the path coming from |
bdukes
approved these changes
Mar 9, 2026
Contributor
|
One more fix coming, it's picking up files marked with |
85d69b7 to
780e9aa
Compare
valadas
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent changes to the module packaging script meant that some files were not being packaged. This PR aims to fix that.