Add CDV cache buster argument to Persona Bar loads#7074
Merged
donker merged 1 commit intodnnsoftware:developfrom Mar 6, 2026
Merged
Add CDV cache buster argument to Persona Bar loads#7074donker merged 1 commit intodnnsoftware:developfrom
donker merged 1 commit intodnnsoftware:developfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7066
Summary
In 10.2.3, some of the Persona Bar extensions were migrated from webpack to Rsbuild. One of the consequences of this change is that the CSS for those modules moved out of the JS bundle into a CSS file. Specifically, in 10.2.2,
/DesktopModules/Admin/Dnn.PersonaBar/Modules/Dnn.Servers/css/Servers.csswas empty, whereas in 10.2.3 it's 20kb (and/DesktopModules/Admin/Dnn.PersonaBar/Modules/Dnn.Servers/scripts/bundles/servers-bundle.jswent from 592kb to 506kb).Previously, the webpack runtime dynamically loaded that CSS, now it is loaded externally by DNN via its Persona Bar infrastructure. For each Persona Bar component it loads, DNN looks for a file sharing the name of the component in a
cssdirectory, socss/Servers.cssgets loaded automatically in 10.2.3 and everything works as expected.However, the way that the CSS file is requested causes it to be cached by the browser. So, in the upgrade scenario, the old empty
Servers.cssis served instead of the new version that has content. Because the Persona Bar is dynamically loaded in aniframe, even doing a hard refresh in the browser does not clear this cache (but using browser dev tools with caching disabled does). Therefore, this PR adds a cache buster parameter to those CSS requests.