Don't blow up when sending email without portal#7058
Merged
bdukes merged 1 commit intodnnsoftware:release/10.2.3from Mar 3, 2026
Merged
Don't blow up when sending email without portal#7058bdukes merged 1 commit intodnnsoftware:release/10.2.3from
bdukes merged 1 commit intodnnsoftware:release/10.2.3from
Conversation
mitchelsellers
approved these changes
Mar 3, 2026
Contributor
|
@bdukes since this is a regression in 10.2.3, should we fix that branch? |
Contributor
Author
|
Yup, I hadn't looked closely at where I'd introduced the issue. I've changed the base branch for the PR |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
donker
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7052
This PR causes the mail providers to fall back to a portal ID of
-1ifPortalSettings.Currentisnull. This prevents aNullReferenceException.Ideally, there would be a way to specify a portal when sending an email from a scheduled task. We could add a property to
MailInfoto support that scenario.